tankui: Hook up skeletal mesh and animations to player controller #20

xury · 2026-03-09T02:10:21Z

xury commented

2026-03-09 02:10:21 +00:00

No description provided.

xury requested reviews from noahg, a_kimb0, TranquilMarmot

2026-03-09 02:10:43 +00:00

noahg requested changes

2026-03-09 05:36:33 +00:00

noahg left a comment

Looks good except for one inadvertent removal of a UID that I mentioned below.

entities/characters/player/player.tscn Outdated

					
				@ -6,3 +7,3 @@

				[ext_resource type="PackedScene" uid="uid://cut0xqkjiyjcu" path="res://art_assets/characters/tanuki/tanuki.gltf" id="4_wqnow"]

				[ext_resource type="PackedScene" uid="uid://cbmtu6xl7vxvq" path="res://entities/characters/player/selection_bounding_box_ui.tscn" id="5_lbevp"]

				[ext_resource type="Script" uid="uid://c3a6bue5mdwbb" path="res://entities/characters/player/player_interaction_handler.gd" id="6_sybl7"]

				[ext_resource type="Script" path="res://entities/characters/player/player_interaction_handler.gd" id="6_sybl7"]

I'm not sure why Godot keeps going back and forth adding and removing UIDs like this. When I check out this branch, reload the project, then open player.tscn and save it, Godot puts this UID back as it was. Given that, I'm concluding that this UID should be kept. Please edit this commit and drop this hunk.

I'm not sure why Godot keeps going back and forth adding and removing UIDs like this. When I check out this branch, reload the project, then open `player.tscn` and save it, Godot puts this UID back as it was. Given that, I'm concluding that this UID should be kept. Please edit this commit and drop this hunk.